classification
Title: IDLE parenmatch - highlighting options
Type: enhancement Stage: patch review
Components: IDLE Versions: Python 3.7, Python 3.6
process
Status: open Resolution:
Dependencies: 22705 27099 Superseder:
Assigned To: terry.reedy Nosy List: terry.reedy, wohlganger
Priority: low Keywords: patch

Created on 2017-06-29 20:36 by wohlganger, last changed 2017-09-14 15:13 by wohlganger.

Pull Requests
URL Status Linked Edit
PR 3574 open wohlganger, 2017-09-14 15:12
Messages (9)
msg297317 - (view) Author: Charles Wohlganger (wohlganger) * Date: 2017-06-29 20:36
Current IDLE parenmatch highlighting uses the 'hilite' style when highlighting the parens/expression.

Desired behavior is to use a user-setting based style that is independent from the hilite style (which is used for highlighting selected text). Desired selectable options are for foreground color, background color, underlining and font (which covers font type, size, bold, and italics)

Apart from running IDLE and checking that the selections match, I don't know how to test. Testing would need a human to check for correct colors, etc. if it was made, so it couldn't be automated...
msg297340 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-06-30 01:51
I am not willing to add a new theme element to the 13 that already exist, let alone define it in config-extensions.def rather than in config-hightlight.def.  It is too much additional complication for too little impact.  Also, any theme specified in config-extensions would likely not work if the user switches between dark and light text.  Theme sets work together.

I will consider letting users select which of the existing 13 to use.  This requires that users be able to know what the 13 choices are.  Hence  the dependence on #22705.

I might also look at the visual effect of underlining.
msg297404 - (view) Author: Charles Wohlganger (wohlganger) * Date: 2017-06-30 13:55
The pull request has been changed to only have the theme element able to be selected. #22705 hasn't had activity in a few years. Is there something I can do to move it along?
msg297442 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-06-30 18:59
As far as you want to go with
1. Review the uploaded patch here or on Rietveld (see review link).
   Or skip this if you make PR and review on github.
2. Download code, makes minimal changes needed to succeed with 'git apply download' in new branch.
3. git commit -m "Patch by Saimadhav Heblikar updated to 3.7"
4. (Optional) test, make changes needed to pass, commit.
5. Make PR and comment or review on github.
msg297443 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-06-30 19:09
There is another option.  I want to incorporate 'builtin extensions' as regular features (#27099), and move their configuration options to other tabs, which will need some reworking.  #22705 will then be less urgent. Selection from a finite set will then be from a dropdown box, like similar non-extension options. Thus #27099, which waiting on current work in process on ConfigDialog, is an alternate dependency.
msg297446 - (view) Author: Charles Wohlganger (wohlganger) * Date: 2017-06-30 22:00
Implimenting #27099 seems the more reasonable solution to me, so I'll work on that when I have free time.
msg297452 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-06-30 22:38
Since configdialog code is being re-written, I would not want to write code right now.  But we could start planning.
msg297905 - (view) Author: Charles Wohlganger (wohlganger) * Date: 2017-07-07 19:23
I've rolled pretty much all this was going to do, other than underlining and font work into #27099. Trying to bring parenmatch into main otherwise would have been just as much of a hassle.
msg300827 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-08-25 05:47
As I said on #27099, please do not include new options with the transfer patch.
History
Date User Action Args
2017-09-14 15:13:01wohlgangersetpull_requests: - pull_request2554
2017-09-14 15:12:22wohlgangersetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request3565
2017-08-25 05:47:15terry.reedysetmessages: + msg300827
2017-07-07 19:23:18wohlgangersetmessages: + msg297905
2017-06-30 22:38:39terry.reedysetdependencies: + IDLE: turn built-in extensions into regular modules
messages: + msg297452
2017-06-30 22:00:14wohlgangersetmessages: + msg297446
2017-06-30 19:09:54terry.reedysetmessages: + msg297443
2017-06-30 18:59:36terry.reedysetmessages: + msg297442
2017-06-30 13:55:40wohlgangersetmessages: + msg297404
2017-06-30 01:51:41terry.reedysetpriority: normal -> low

dependencies: + Idle extension configuration: add option-help option
messages: + msg297340
stage: needs patch
2017-06-29 20:39:41wohlgangersetpull_requests: + pull_request2554
2017-06-29 20:36:07wohlgangercreate