msg67376 - (view) |
Author: Benjamin Peterson (benjamin.peterson) * |
Date: 2008-05-26 17:15 |
When compiling the _ssl extension on MacOS 10.4, I get these warnings:
/users/benjamin/python/trunk/Modules/_ssl.c: In function
'_get_peer_alt_names':
/users/benjamin/python/trunk/Modules/_ssl.c:694 warning: passing
argument 2 of 'ASN1_item_d2i' from incompatible pointer type
/users/benjamin/python/trunk/Modules/_ssl.c:698: warning: passing
argument 2 of 'method->d2i' from incompatible pointer type
|
msg67468 - (view) |
Author: Alexander Belopolsky (belopolsky) * |
Date: 2008-05-29 04:02 |
It looks like this comes from r59493 which purports to fix a warning:
------------------------------------------------------------------------
r59493 | christian.heimes | 2007-12-13 23:38:13 -0500 (Thu, 13 Dec 2007)
| 1 line
Fixed warning in ssl module
------------------------------------------------------------------------
--- Modules/_ssl.c (revision 59492)
+++ Modules/_ssl.c (revision 59493)
@@ -660,7 +660,7 @@
char buf[2048];
char *vptr;
int len;
- unsigned char *p;
+ const unsigned char *p;
if (certificate == NULL)
return peer_alt_names;
On MacOS 10.4 with OpenSSL 0.9.7i, ASN1_item_d2i is declared without
const, so reverting fixes the warning.
I guess Christian was developing on a system with a different OpenSSL
version, so we need to hear from him before attempting another fix.
|
msg68915 - (view) |
Author: Bill Janssen (janssen) * |
Date: 2008-06-28 21:35 |
Any progress here? I haven't yet found a formulation which suppresses
the warning on all platforms. I'm guessing there will have to be some
kind of cpp test
#if SOMEFEATURE
#define D2I_PARAMETER_2_TYPE unsigned char *
#else
#define D2I_PARAMETER_2_TYPE const unsigned char *
#endif
|
msg68917 - (view) |
Author: Benjamin Peterson (benjamin.peterson) * |
Date: 2008-06-28 21:58 |
Yes, although I have no idea what that feature may be... (sigh) Oh well,
it's a wish.
|
msg87916 - (view) |
Author: Daniel Diniz (ajaksu2) * |
Date: 2009-05-16 19:39 |
Would HEADER_ASN1_MAC_H or IMPLEMENT_ASN1_ENCODE_FUNCTIONS_const_fname help?
|
msg92105 - (view) |
Author: Daniel Black (grooverdan) * |
Date: 2009-08-31 07:26 |
The changeset that changed the definitions is here:
http://cvs.openssl.org/chngview?cn=12024 (2004-Mar-14 23:15:13 (UTC))
As you can see there is no easy identifier in the changeset (i'm not
sure how portable an ifdef on a typedef is (possible
asn1_const_ctx_st/ASN1_const_CTX)).
The patch i've done goes of then next OPENSSL_VERSION_NUMBER change
which occurred here
http://cvs.openssl.org/filediff?f=openssl/crypto/opensslv.h&v1=1.36.2.35&v2=1.36.2.36
(2004/03/17 11:40:44) ~3 days later.
Same patch applies to p3k
|
msg97506 - (view) |
Author: Florent Xicluna (flox) * |
Date: 2010-01-10 11:11 |
Still occurs on dev and py3k.
And patch applies correctly.
|
msg97507 - (view) |
Author: Florent Xicluna (flox) * |
Date: 2010-01-10 11:13 |
It occurs on Debian Lenny AMD64.
|
msg100315 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2010-03-02 22:53 |
I commited grooverdan's patch: r78596 (trunk), r78597 (2.6), r78598 (py3k), 78599 (3.1).
The API was changed in... 2004, 6 years ago! I hope that everybody upgraded to the new OpenSSL version since that. Anyway, the warning should be fixed, and Python should be compatible with any OpenSSL version.
|
msg100340 - (view) |
Author: Barry A. Warsaw (barry) * |
Date: 2010-03-03 12:38 |
Because we're in release candidate mode, I reverted the change to the release26-maint branch. It doesn't seem critical enough to sneak in between rc and final. Please do re-apply after 2.6.5 final is released though!
|
msg100344 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2010-03-03 14:27 |
barry> Because we're in release candidate mode,
barry> I reverted the change to the release26-maint branch.
Yeah, sorry. I realized that after backporting the fix to 2.6.
barry> Please do re-apply after 2.6.5 final is released though!
Ok. I reopened to issue to not forget.
|
msg100402 - (view) |
Author: Florent Xicluna (flox) * |
Date: 2010-03-04 17:58 |
On Gentoo buildbots (2.x and 3.x), there's still the same compiler warnings:
http://www.python.org/dev/buildbot/all/builders/x86%20gentoo%20trunk/builds/5899
/home/buildslave/python-trunk/trunk.norwitz-x86/build/Modules/_ssl.c:706: warning: passing arg 2 of `ASN1_item_d2i' from incompatible pointer type
/home/buildslave/python-trunk/trunk.norwitz-x86/build/Modules/_ssl.c:710: warning: passing arg 2 of pointer to function from incompatible pointer type
|
msg125559 - (view) |
Author: Antoine Pitrou (pitrou) * |
Date: 2011-01-06 15:46 |
I don't get any warnings with gcc -Wall and OpenSSL 1.0.x.
|
msg125603 - (view) |
Author: Daniel Black (grooverdan) * |
Date: 2011-01-06 23:21 |
out of date?
still occurs on:
AMD64 Leopard 2.7: http://www.python.org/dev/buildbot/all/builders/AMD64 Leopard 2.7/builds/308/steps/compile/logs/warnings (57)
PPC Leopard 2.7: http://www.python.org/dev/buildbot/all/builders/PPC Leopard 2.7/builds/532/steps/compile/logs/warnings (20)
PPC Tiger 2.7: http://www.python.org/dev/buildbot/all/builders/PPC Tiger 2.7/builds/532/steps/compile/logs/warnings (25)
PPC Leopard 3.1: http://www.python.org/dev/buildbot/all/builders/PPC Leopard 3.1/builds/674/steps/compile/logs/warnings (20)
x86 gentoo 3.1 : http://www.python.org/dev/buildbot/all/builders/x86 gentoo 3.1/builds/1412/steps/compile/logs/warnings (8)
x86 FreeBSD 3.1: http://www.python.org/dev/buildbot/all/builders/x86 FreeBSD 3.1/builds/719/steps/compile/logs/warnings (7)
3.1.dmg: http://www.python.org/dev/buildbot/all/builders/3.1.dmg/builds/339/steps/compile/logs/warnings (20)
btw I don't think the gentoo ones are accurate - old versions of openssl have been gone for a while:
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/dev-libs/openssl/openssl-0.9.7m.ebuild?hideattic=0&view=log
|
msg125643 - (view) |
Author: Antoine Pitrou (pitrou) * |
Date: 2011-01-07 13:31 |
Well, it merely means that OpenSSL has changed the const-ness of some of their APIs over time. As I said I see no warnings with the most recent OpenSSL versions. Buildbots will tell you the same story: for example, no warnings under OS X "Snow Leopard", some under OS X "Leopard" (which is older).
|
|
Date |
User |
Action |
Args |
2022-04-11 14:56:34 | admin | set | github: 47222 |
2011-01-07 13:31:17 | pitrou | set | nosy:
barry, janssen, belopolsky, pitrou, vstinner, christian.heimes, ajaksu2, benjamin.peterson, grooverdan, flox messages:
+ msg125643 |
2011-01-06 23:21:34 | grooverdan | set | nosy:
barry, janssen, belopolsky, pitrou, vstinner, christian.heimes, ajaksu2, benjamin.peterson, grooverdan, flox messages:
+ msg125603 |
2011-01-06 15:46:39 | pitrou | set | status: open -> closed
nosy:
+ pitrou messages:
+ msg125559
resolution: out of date |
2010-03-04 17:58:49 | flox | set | messages:
+ msg100402 |
2010-03-03 14:27:47 | vstinner | set | status: closed -> open resolution: fixed -> (no value) messages:
+ msg100344
|
2010-03-03 12:38:32 | barry | set | nosy:
+ barry messages:
+ msg100340
|
2010-03-02 22:53:17 | vstinner | set | status: open -> closed resolution: fixed |
2010-03-02 22:53:02 | vstinner | set | nosy:
+ vstinner messages:
+ msg100315
|
2010-01-10 11:13:56 | flox | set | messages:
+ msg97507 |
2010-01-10 11:11:23 | flox | set | nosy:
+ flox
messages:
+ msg97506 versions:
- Python 3.0 |
2009-08-31 07:26:04 | grooverdan | set | files:
+ issue2973-D2I_PARAMETER_2_TYPE.patch versions:
+ Python 3.0, Python 3.1, Python 2.7, Python 3.2 nosy:
+ grooverdan
messages:
+ msg92105
keywords:
+ patch |
2009-05-16 19:39:32 | ajaksu2 | set | nosy:
+ ajaksu2 messages:
+ msg87916
|
2008-06-28 21:58:48 | benjamin.peterson | set | priority: normal -> low messages:
+ msg68917 |
2008-06-28 21:35:57 | janssen | set | nosy:
+ janssen messages:
+ msg68915 |
2008-05-29 04:02:37 | belopolsky | set | nosy:
+ christian.heimes, belopolsky messages:
+ msg67468 |
2008-05-26 17:15:22 | benjamin.peterson | create | |