classification
Title: TimedRotatingFileHandler crashes on backup file deletion attempt
Type: crash Stage:
Components: Library (Lib) Versions: Python 2.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: vinay.sajip Nosy List: blocki, vinay.sajip
Priority: normal Keywords:

Created on 2008-05-20 12:34 by blocki, last changed 2008-05-20 15:43 by vinay.sajip. This issue is now closed.

Messages (2)
msg67125 - (view) Author: Stephan Blietz (blocki) Date: 2008-05-20 12:34
Hello,
when the maximum number of backup files is reached
TimedRotatingFileHandler can't delete the oldest existing file. I got
the following error message:

Traceback (most recent call last):
  File "D:\Python25\lib\logging\handlers.py", line 75, in emit
    self.doRollover()
  File "D:\Python25\lib\logging\handlers.py", line 319, in doRollover
    os.remove(s)
WindowsError: [Error 2] The system cannot find the file specified:
'assyst.log.2008-05-20_12-49'

The reason for this error is located in the getFilesToDelete method of
the TimedRotatingFileHandler class. The result sequence of this method
contains filenames but a complete filepath is needed.

After replacing 
    result.append(fileName) 
with
    result.append(os.path.join(dirName, fileName))
the problem seems to be solved

Regards
Stephan
msg67131 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2008-05-20 15:43
Fix checked into trunk (r63507). Thanks for the report!
History
Date User Action Args
2008-05-20 15:43:08vinay.sajipsetstatus: open -> closed
resolution: fixed
messages: + msg67131
2008-05-20 14:42:57georg.brandlsetassignee: vinay.sajip
nosy: + vinay.sajip
2008-05-20 12:34:09blockicreate