classification
Title: Drop __aiter__ compatibility layer from 3.7
Type: behavior Stage: resolved
Components: Interpreter Core Versions: Python 3.7
process
Status: closed Resolution: duplicate
Dependencies: Superseder: Drop support for asynchronous __aiter__
View: 31709
Assigned To: yselivanov Nosy List: serhiy.storchaka, vstinner, yselivanov
Priority: normal Keywords: patch

Created on 2016-11-09 01:09 by yselivanov, last changed 2017-10-23 16:17 by yselivanov. This issue is now closed.

Files
File name Uploaded Description Edit
aiter.patch yselivanov, 2016-11-09 01:11 review
Messages (4)
msg280369 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2016-11-09 01:11
As discussed in issue #27243, we want to drop __aiter__ compatibility layer in Python 3.7.  Please take a look at the attached patch (I'll inc importlib's magic before committing).
msg280376 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2016-11-09 07:12
> I'll inc importlib's magic before committing.

Please left good gap for possible bugfixes between current number and 3.7 number. Set it to 3390.

I'm not experienced with async protocols, but at first glance the patch looks technically correct. Please update the documentation. I have the only question about tests. Some tests test the behavior with "async __aiter__". With the patch them test the behavior with just "__aiter__". Shouldn't these tests be duplicated in 3.5-3.6 for __aiter__ without async?
msg304813 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-10-23 15:56
Do you mind to create a pull request Yury?
msg304820 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2017-10-23 16:17
Already resolved as part of https://bugs.python.org/issue31709. Closing this one.
History
Date User Action Args
2017-10-23 16:17:55yselivanovsetstatus: open -> closed
superseder: Drop support for asynchronous __aiter__
messages: + msg304820

resolution: duplicate
stage: patch review -> resolved
2017-10-23 15:56:49serhiy.storchakasetmessages: + msg304813
2016-11-09 07:12:38serhiy.storchakasetmessages: + msg280376
2016-11-09 01:11:27yselivanovsetfiles: + aiter.patch
keywords: + patch
messages: + msg280369
2016-11-09 01:09:18yselivanovcreate