classification
Title: test_huntrleaks_fd_leak fails on Windows
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, berker.peksag, python-dev, vstinner
Priority: normal Keywords:

Created on 2016-09-18 11:03 by berker.peksag, last changed 2016-09-19 10:01 by berker.peksag. This issue is now closed.

Messages (7)
msg276878 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2016-09-18 11:03
From http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/11654/steps/test/logs/stdio

======================================================================
FAIL: test_huntrleaks_fd_leak (test.test_regrtest.ArgsTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\test_regrtest.py", line 782, in test_huntrleaks_fd_leak
    self.assertEqual(reflog, line2)
AssertionError: 'test[27 chars] [1, 2, 2] memory blocks, sum=5\ntest_regrtest[50 chars]=3\n' != 'test[27 chars] [1, 1, 1] file descriptors, sum=3\n'
- test_regrtest_huntrleaks leaked [1, 2, 2] memory blocks, sum=5
  test_regrtest_huntrleaks leaked [1, 1, 1] file descriptors, sum=3
msg276883 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2016-09-18 11:30
It looks like http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/11581 is first time that the test was failed.

Revisions (without documentation changes) in that build:

* 378e000a68785fdb3d74b3a930bc4ac5f6a04ce5
* fc8aaa073eb4253b84e8af6de7ea45e4a3724b28
* 48a1f97d03b4851ec6435453d319acdaeaf8becb
* 50cb3c6f5f725f07d7ac7388567f41e5950dd0fc
* d1dace3c9871037b350f88aaa1979b5a481f2a26
msg276920 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-09-18 22:13
New changeset 91285b24f1c2 by Victor Stinner in branch '3.6':
Fix test_huntrleaks_fd_leak() of test_regrtest
https://hg.python.org/cpython/rev/91285b24f1c2
msg276923 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2016-09-18 22:20
I modified the test_regrtest unit test because the test is too fragile, it expects a line on a specific line number.

But there is still a real memory leak detected by this unit test.
msg276925 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2016-09-18 22:56
Ah, I found a leak: see issue #28200.
msg276968 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2016-09-19 10:00
FYI there was a real memory leak and I just fixed it with the change 6232e610e310.
msg276969 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2016-09-19 10:01
Thanks Victor!
History
Date User Action Args
2016-09-19 10:01:05berker.peksagsetmessages: + msg276969
stage: needs patch -> resolved
2016-09-19 10:00:32vstinnersetstatus: open -> closed
resolution: fixed
messages: + msg276968
2016-09-18 22:56:57vstinnersetmessages: + msg276925
2016-09-18 22:20:30vstinnersetmessages: + msg276923
2016-09-18 22:13:35python-devsetnosy: + python-dev
messages: + msg276920
2016-09-18 11:30:32berker.peksagsetnosy: + vstinner, benjamin.peterson
messages: + msg276883
2016-09-18 11:03:16berker.peksagcreate