The description of abs() says "If the argument is a complex number, its magnitude is returned." but test_builtin doesn't include any complex number test cases.

I think tests for abs() using complex numbers are already in test_cmath.  How do they look?

test_cmath includes abs() of zeros, infinities, and real or imaginary part
NaN, but does not include a test for the magnitude conversion, which would
be triggered by something like
>>> abs(complex(2.1,3.5))
4.08166632639171
>>> abs(complex('2.1+3.5j'))
4.08166632639171

And in looking through test_cmath, it appears that only the two numeric
argument form of complex(i, j) is tested for any of the functions, not the
complex('i+nj') string form.

On Sun, Aug 14, 2016 at 1:48 PM, Ned Deily <report@bugs.python.org> wrote:

>
> Ned Deily added the comment:
>
> I think tests for abs() using complex numbers are already in test_cmath.
> How do they look?
>
> ----------
> nosy: +ned.deily
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <http://bugs.python.org/issue27763>
> _______________________________________
>

> in looking through test_cmath, it appears that only the two numeric
> argument form of complex(i, j) is tested for any of the functions, not the
> complex('i+nj') string form.

We're testing the cmath functions on complex number inputs; I don't think it matters much how those complex numbers are created. The string form of the constructor can't create any complex numbers that the two-argument `complex(x, y)` form can't, so we're not losing test coverage by only using the `complex(x, y)` form.

The complex number creation from both strings and pairs of floats should be tested independently, of course.

> We're testing the cmath functions on complex number inputs

Indeed.  Also, for abs(complex) - there is test_abs() in the test_complex.py.

> The complex number creation from both strings and pairs of floats should be tested independently, of course.

It seems, there are such tests as well.  E.g. test_constructor() in the same file.

Mark, perhaps this can be closed?

Yes, it looks as though we do have tests of the form that Evelyn describes in test_complex (which also seems like the right place for those tests).

Closing here. Thanks Sergey for the ping!