➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2016-08-10 17:58 by matrixise, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue27728.diff | matrixise, 2016-08-10 17:59 | review | ||
| Messages (7) | |||
|---|---|---|---|
| msg272352 - (view) | Author: Stéphane Wirtel (matrixise) *  |
Date: 2016-08-10 17:58 | |
http.client.HTTPConnection.request, the argument 'headers' has a default value, and this one is a mutable (dict). |
|||
| msg272353 - (view) | Author: Stéphane Wirtel (matrixise) * |
Date: 2016-08-10 17:59 | |
here is my patch for that. |
|||
| msg272356 - (view) | Author: SilentGhost (SilentGhost) *  |
Date: 2016-08-10 18:11 | |
Why is that an issue? |
|||
| msg272359 - (view) | Author: R. David Murray (r.david.murray) * |
Date: 2016-08-10 18:53 | |
Well, it's a problem in general because if the called routine modifies the default dict...the default is modified. I'm guessing it is never modified, but it is indeed better future proofing of the code to not use a mutable default in a routine that passes the variable to other functions, as this one does. |
|||
| msg272364 - (view) | Author: Stéphane Wirtel (matrixise) * |
Date: 2016-08-10 19:20 | |
Thanks R.David.Murray, @SilentGhost in fact, in this code, it's not an issue but we use a bad practice and not a good practice with a mutable value. |
|||
| msg272380 - (view) | Author: Martin Panter (martin.panter) * |
Date: 2016-08-10 22:36 | |
If the code does happen to mutate the dictionary, there would still be a bug with modifying any dictionary passed in by the caller. But I suspect there is no bug. So I am not sure the change is worth it. If we do go ahead, the documentation needs updating to say None is now allowed. |
|||
| msg272389 - (view) | Author: R. David Murray (r.david.murray) * |
Date: 2016-08-11 00:36 | |
Yes, this is one of those cases where the benefit of the change is probably outweighed by the cost. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:34 | admin | set | github: 71915 |
| 2017-05-24 12:42:53 | matrixise | set | status: open -> closed stage: patch review -> resolved |
| 2017-05-24 12:42:35 | matrixise | set | resolution: not a bug |
| 2016-08-11 00:36:32 | r.david.murray | set | messages: + msg272389 |
| 2016-08-10 22:36:12 | martin.panter | set | nosy:
+ martin.panter messages: + msg272380 |
| 2016-08-10 20:11:26 | matrixise | set | stage: patch review |
| 2016-08-10 19:20:50 | matrixise | set | messages: + msg272364 |
| 2016-08-10 18:53:43 | r.david.murray | set | nosy:
+ r.david.murray messages: + msg272359 |
| 2016-08-10 18:11:55 | SilentGhost | set | nosy:
+ SilentGhost messages: + msg272356 |
| 2016-08-10 17:59:04 | matrixise | set | files:
+ issue27728.diff keywords: + patch messages: + msg272353 |
| 2016-08-10 17:58:34 | matrixise | create | |