classification
Title: turtle.fillcolor doesn't accept a tuple of floats
Type: enhancement Stage: patch review
Components: Library (Lib) Versions: Python 3.6
process
Status: open Resolution:
Dependencies: 21916 Superseder:
Assigned To: Jelle Zijlstra Nosy List: Jelle Zijlstra, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2016-06-04 16:29 by Jelle Zijlstra, last changed 2016-06-05 16:18 by Jelle Zijlstra.

Files
File name Uploaded Description Edit
issue27219.patch Jelle Zijlstra, 2016-06-05 00:21 patch adding support for float color tuples review
issue27219-cr.patch Jelle Zijlstra, 2016-06-05 16:18 review
Messages (3)
msg267263 - (view) Author: Jelle Zijlstra (Jelle Zijlstra) * (Python triager) Date: 2016-06-04 16:29
But `turtle.pencolor()` returns a tuple of floats, so calling `turtle.fillcolor(turtle.pencolor())`. This issue shows up in the doctest at library/turtle.rst line 936. I can submit a patch with tests once the tests in issue21916 are in.
msg267394 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2016-06-05 07:08
_color_triple_to_hexstring() is implementation detail. It would be better to test it indirectly using public method (like fillcolor()). Added other comments on Rietveld.
msg267423 - (view) Author: Jelle Zijlstra (Jelle Zijlstra) * (Python triager) Date: 2016-06-05 16:18
New patch
History
Date User Action Args
2016-06-05 16:18:41Jelle Zijlstrasetfiles: + issue27219-cr.patch

messages: + msg267423
2016-06-05 07:08:56serhiy.storchakasetnosy: + serhiy.storchaka

messages: + msg267394
stage: patch review
2016-06-05 00:21:52Jelle Zijlstrasetfiles: + issue27219.patch
keywords: + patch
2016-06-04 17:37:06serhiy.storchakasetdependencies: + Create unit tests for turtle textonly
type: enhancement
2016-06-04 16:29:00Jelle Zijlstracreate