This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: make compiling struct be passed around to all ast helpers
Type: enhancement Stage:
Components: Interpreter Core Versions: Python 2.6
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: benjamin.peterson Nosy List: benjamin.peterson, christian.heimes, georg.brandl
Priority: normal Keywords: patch

Created on 2008-04-29 21:42 by benjamin.peterson, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
ast_compiling_struct.patch benjamin.peterson, 2008-04-29 21:41
Messages (5)
msg65982 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-04-29 21:41
This patch causes struct *compiling to be passed around to all of the
ast helper functions. Since most functions already take it, this makes
it more consistent as a whole. Also, the filename (from
compiling->c_filename) is needed to issue warnings with PyErr_WarnExplicit.
msg65983 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2008-04-29 21:44
+1 for the feature
msg66062 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-05-02 02:57
Georg, is it all right if I apply this?
msg66144 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2008-05-03 07:08
Sure, if it still compiles. :)
msg66156 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-05-03 15:58
Done in r62663.
History
Date User Action Args
2022-04-11 14:56:33adminsetgithub: 46972
2008-05-03 15:58:46benjamin.petersonsetstatus: open -> closed
resolution: accepted
messages: + msg66156
2008-05-03 07:08:07georg.brandlsetassignee: georg.brandl -> benjamin.peterson
messages: + msg66144
2008-05-02 21:15:33benjamin.petersonlinkissue2349 dependencies
2008-05-02 02:57:48benjamin.petersonsetassignee: georg.brandl
messages: + msg66062
nosy: + georg.brandl
2008-04-29 21:44:20christian.heimessetnosy: + christian.heimes
messages: + msg65983
2008-04-29 21:42:04benjamin.petersoncreate