Title: Make concurrent.futures.Executor an abc
Type: enhancement Stage:
Components: Versions: Python 3.6, Python 3.5
Status: closed Resolution: wont fix
Dependencies: Superseder:
Assigned To: Nosy List: bquinlan, xiang.zhang
Priority: normal Keywords: patch

Created on 2016-04-21 11:01 by xiang.zhang, last changed 2016-05-26 14:13 by xiang.zhang. This issue is now closed.

File name Uploaded Description Edit
make_concurrent_futures_Executor_an_abc.patch xiang.zhang, 2016-04-21 11:01 review
make_concurrent_futures_Executor_an_abc_v2.patch xiang.zhang, 2016-04-21 11:58 review
Messages (2)
msg263911 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2016-04-21 11:01
The documentation tells that concurrent.futures.Executor is an abstract class. Also PEP3148 tells so and says concurrent.futures.Executor.submit is an abstract method and must be implemented by Executor subclasses. I think using abc.ABCMeta here is a good choice.

I propose a patch. The patch also remove some unnecessary object base class.
msg263914 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2016-04-21 11:58
Update the patch to remove more unnecessary base object.
Date User Action Args
2016-05-26 14:13:07xiang.zhangsetstatus: open -> closed
resolution: wont fix
2016-04-21 12:14:44xiang.zhangsettype: enhancement
versions: + Python 3.5, Python 3.6
2016-04-21 11:58:56xiang.zhangsetfiles: + make_concurrent_futures_Executor_an_abc_v2.patch

messages: + msg263914
2016-04-21 11:01:52xiang.zhangcreate