classification
Title: xmlrpc.server imports xmlrpc.client
Type: enhancement Stage:
Components: Library (Lib) Versions: Python 3.6
process
Status: closed Resolution: wont fix
Dependencies: Superseder:
Assigned To: Nosy List: Valentin.Lorentz, brett.cannon, loewis, serhiy.storchaka
Priority: normal Keywords:

Created on 2016-03-25 11:56 by Valentin.Lorentz, last changed 2016-03-25 17:08 by brett.cannon. This issue is now closed.

Messages (4)
msg262428 - (view) Author: ProgVal (Valentin.Lorentz) Date: 2016-03-25 11:56
from xmlrpc.client import Fault, dumps, loads, gzip_encode, gzip_decode

Shouldn't these class/functions be moved to a new module, with a name like xmlrpc.common?
msg262435 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2016-03-25 12:31
Moving public classes and functions to other module can break pickle compatibility.
msg262443 - (view) Author: ProgVal (Valentin.Lorentz) Date: 2016-03-25 14:42
Even if xmlrpc.client imported them in its namespace?
msg262444 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2016-03-25 17:08
Yes because the location of the object is based on where it's defined, not where you got it from.

While I get the motivation to be a little cleaner in the xmlrpc package, "practicality beats purity" here in that the reorg isn't worth it at this point in the face of potentially breaking code for little benefit.

Closing as "wont fix"; sorry, Valentin.
History
Date User Action Args
2016-03-25 17:08:28brett.cannonsetstatus: open -> closed

nosy: + brett.cannon
messages: + msg262444

resolution: wont fix
2016-03-25 14:42:20Valentin.Lorentzsetmessages: + msg262443
2016-03-25 12:31:59serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg262435
2016-03-25 12:09:13SilentGhostsetnosy: + loewis

versions: + Python 3.6, - Python 3.4
2016-03-25 11:56:15Valentin.Lorentzcreate