classification
Title: PC\bdist_wininst\install.c: Missing call to fclose()
Type: Stage:
Components: Windows Versions:
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: Josh Snider, aatishnn, maddin200, martin.panter, paul.moore, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: easy, patch

Created on 2016-03-14 10:01 by maddin200, last changed 2016-04-17 08:28 by martin.panter.

Files
File name Uploaded Description Edit
issue26554.patch aatishnn, 2016-03-19 04:00 For 3.6 review
Messages (3)
msg261737 - (view) Author: (maddin200) Date: 2016-03-14 10:01
cpython\PC\bdist_wininst\install.c line 2542
missing fclose(logfile);
msg263597 - (view) Author: Josh Snider (Josh Snider) * Date: 2016-04-17 03:34
I suggested some changes to your patch. Your patch should also add your name to the Misc/ACKS file as I don't currently see an Aatish listed there.
msg263601 - (view) Author: Martin Panter (martin.panter) * (Python committer) Date: 2016-04-17 08:28
Adding aatishnn to nosy in case they aren’t aware of your review.
History
Date User Action Args
2016-04-17 08:28:19martin.pantersetnosy: + aatishnn, martin.panter
messages: + msg263601
2016-04-17 03:34:44Josh Snidersetnosy: + Josh Snider
messages: + msg263597
2016-03-19 04:00:48aatishnnsetfiles: + issue26554.patch
keywords: + patch
2016-03-17 16:39:54vstinnersettitle: Missing fclose -> PC\bdist_wininst\install.c: Missing call to fclose()
2016-03-17 16:39:39vstinnersetkeywords: + easy
2016-03-14 10:01:41maddin200create