classification
Title: trace module crashes due to using wrong sort idiom
Type: behavior Stage:
Components: Library (Lib) Versions: Python 3.0
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: gpolo, loewis, mark
Priority: normal Keywords: patch

Created on 2008-04-10 12:19 by mark, last changed 2008-04-10 19:03 by loewis. This issue is now closed.

Files
File name Uploaded Description Edit
issue_2606.diff gpolo, 2008-04-10 16:26
Messages (3)
msg65290 - (view) Author: Mark Summerfield (mark) * Date: 2008-04-10 12:19
In Py30a4's trace.py there is this:

    calls = self.calledfuncs.keys()
    calls.sort()

which causes:
    AttributeError: 'dict_keys' object has no attribute 'sort'

There are two other occurrences of this idiom in trace.py (just search
for ".sort"). I guess they should be easy to fix.
msg65294 - (view) Author: Guilherme Polo (gpolo) * (Python committer) Date: 2008-04-10 16:26
I've changed them to sorted(obj.keys())
msg65308 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2008-04-10 19:03
I've further simplified the code by eliminating the local variables, and
committed that as r62270.
History
Date User Action Args
2008-04-10 19:03:06loewissetstatus: open -> closed
resolution: fixed
messages: + msg65308
nosy: + loewis
2008-04-10 16:26:36gpolosetfiles: + issue_2606.diff
keywords: + patch
messages: + msg65294
nosy: + gpolo
2008-04-10 12:19:16markcreate