classification
Title: multiple issues in http.client
Type: behavior Stage: patch review
Components: Library (Lib) Versions: Python 3.6, Python 3.4, Python 3.5, Python 2.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: martin.panter, spaceone
Priority: normal Keywords:

Created on 2015-11-27 00:35 by spaceone, last changed 2015-11-27 02:50 by martin.panter.

Messages (3)
msg255445 - (view) Author: SpaceOne (spaceone) Date: 2015-11-27 00:35
* RESET_CONTENT not evaluated
* negative chunk size accepted
* invalid ports accepted
* success status !== 200 ignored

Patch: https://github.com/spaceone/cpython/commit/3289080306408db971f8b816d3e9f0ab44ed392b

Part of github Pull Request https://github.com/python/cpython/pull/19 from July. Should I split this up into multiple bugtracker issues?
msg255449 - (view) Author: Martin Panter (martin.panter) * (Python committer) Date: 2015-11-27 02:45
Thanks for these fixes. It might be better to open other report(s) for the FIXME comments, so you can explain them better, and propose any ideas or possible solutions. For some of them, it may be more appropriate to just fix them in the next (3.6) release, such as the method case insensitivity thing (to minimize backwards compatibility problems).

It would be good to have regression test cases for each bug fixed.

Regarding folded header field values, I think there was some discussion about deprecating that ability in Issue 22928. Definitely needs a separate report.

See Issue 23740 about various quirks with what objects and automatic encodings are accepted when sending a request. It is already a can of worms; I suggest not to make it any more complicated.

Can you elaborate on accepting invalid ports? Is this related to Issue 24169?
msg255450 - (view) Author: Martin Panter (martin.panter) * (Python committer) Date: 2015-11-27 02:50
I missed seeing the _get_hostport() change in the commit. So you are saying that values out of range 1–65535 should raise InvalidURL("nonnumeric port . . ."). The error message isn’t quite right.
History
Date User Action Args
2015-11-27 02:50:35martin.pantersetmessages: + msg255450
2015-11-27 02:45:27martin.pantersetversions: + Python 2.7, Python 3.4, Python 3.5, Python 3.6
nosy: + martin.panter

messages: + msg255449

type: behavior
stage: patch review
2015-11-27 00:35:22spaceonecreate