classification
Title: Fix regex_compile benchmark crash
Type: crash Stage: resolved
Components: Benchmarks Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: brett.cannon, florin.papa, pitrou, zach.ware
Priority: normal Keywords: patch

Created on 2015-11-23 13:05 by florin.papa, last changed 2015-11-25 13:22 by florin.papa. This issue is now closed.

Files
File name Uploaded Description Edit
fix_regex_compile.patch florin.papa, 2015-11-23 13:05
Messages (3)
msg255152 - (view) Author: Florin Papa (florin.papa) * Date: 2015-11-23 13:05
Hi all,

This is Florin Papa from the Server Languages Optimizations Team at Intel Corporation.

The patch submitted here solves a crash occurring on Python 2.7 and 3.6 when running the regex_compile benchmark. The clear_cache() call was replaced with re.purge().

To apply the patch please follow these steps:

hg clone https://hg.python.org/benchmarks
cd benchmarks/
copy fix_regex_compile.patch to the current directory
hg import --no-commit fix_regex_compile.patch

Thank you,
Florin Papa
msg255320 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2015-11-25 05:31
Fixed in f7283190e896.

I had actually already fixed this in my sandbox repo for speed.python.org; I just went ahead and pushed it (and a couple other very minor changes) to the main benchmark repo.

Thanks for the report and patch!
msg255341 - (view) Author: Florin Papa (florin.papa) * Date: 2015-11-25 13:22
No problem. Thank you for fixing this.
History
Date User Action Args
2015-11-25 13:22:27florin.papasetmessages: + msg255341
2015-11-25 05:31:32zach.waresetstatus: open -> closed

versions: - Python 2.7, Python 3.6
nosy: + zach.ware

messages: + msg255320
resolution: fixed
stage: resolved
2015-11-23 13:05:25florin.papacreate