This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: urllib bypasses all hosts if proxyoverride includes an empty element
Type: behavior Stage: test needed
Components: Windows Versions: Python 3.6, Python 3.5, Python 2.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: Jung-chih Wei, paul.moore, r.david.murray, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2015-10-08 05:05 by Jung-chih Wei, last changed 2022-04-11 14:58 by admin.

Files
File name Uploaded Description Edit
cpython_98592.patch Jung-chih Wei, 2015-10-08 05:06 review
cpython_98593.patch Jung-chih Wei, 2015-10-08 05:06
Messages (5)
msg252510 - (view) Author: Jung-chih Wei (Jung-chih Wei) Date: 2015-10-08 05:05
Windows could append a empty host in ProxyOverride list.
Then, proxy_bypass_registry() will return true for any host.
msg252511 - (view) Author: Jung-chih Wei (Jung-chih Wei) Date: 2015-10-08 05:06
patch for default branch
msg252512 - (view) Author: Jung-chih Wei (Jung-chih Wei) Date: 2015-10-08 05:06
patch for 2.7 branch
msg252536 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2015-10-08 12:39
How does IE itself behave in this case?

Also, we should have a test to go along with the fix.
msg252984 - (view) Author: Jung-chih Wei (Jung-chih Wei) Date: 2015-10-14 11:39
I believe IE ignores the empty element because I must access the internet through proxy.
And please refer to http://mxr.mozilla.org/mozilla-central/source/toolkit/system/windowsproxy/nsWindowsSystemProxySettings.cpp#177, Firefox also ignores the empty element.
History
Date User Action Args
2022-04-11 14:58:22adminsetgithub: 69525
2015-10-14 11:39:02Jung-chih Weisetmessages: + msg252984
2015-10-08 12:39:11r.david.murraysetnosy: + r.david.murray
title: urllib fail to check host whether it should be bypassed -> urllib bypasses all hosts if proxyoverride includes an empty element
messages: + msg252536

versions: - Python 3.2, Python 3.3, Python 3.4
stage: test needed
2015-10-08 05:06:59Jung-chih Weisetfiles: + cpython_98593.patch

messages: + msg252512
2015-10-08 05:06:28Jung-chih Weisetfiles: + cpython_98592.patch
keywords: + patch
messages: + msg252511
2015-10-08 05:05:21Jung-chih Weicreate