This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: PCbuild/*.vcxproj* should use CRLF line endings
Type: behavior Stage: resolved
Components: Build, Windows Versions: Python 3.6, Python 3.5, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: zach.ware Nosy List: paul.moore, steve.dower, tim.golden, zach.ware
Priority: normal Keywords:

Created on 2015-09-17 15:46 by zach.ware, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (3)
msg250893 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2015-09-17 15:46
PCbuild/*.vcxproj* should be added to .hgeol to force them to CRLF.

A couple of reasons:

1) They're only used on Windows, where the default (terrible, but always available) editor doesn't understand LF

2) More importantly, the tcl, tk, and tix projects use labels in the NMakeCommandLine script, which can fail confusingly when that script has LF line endings (the error is "The system cannot find the batch label specified - build")

Thanks to Andres Guzman-ballen for bringing this to my attention again. I have also seen this on my Windows 8.1 Non-Debug buildbot, where I worked around it by turning on the hg 'eol' extension so that everything would be converted to CRLF on checkout.
msg258411 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2016-01-16 21:02
IMHO enabling the eol extension is the right way to deal with this. Especially once the GitHub migration happens - it really doesn't handle CRLF endings (or anything Windows) as well as Mercurial does.
msg303425 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2017-09-30 20:18
This has been done for a while via .gitattributes.
History
Date User Action Args
2022-04-11 14:58:21adminsetgithub: 69340
2017-09-30 20:18:26zach.waresetstatus: open -> closed
resolution: fixed
messages: + msg303425

stage: needs patch -> resolved
2016-01-16 21:02:10steve.dowersetmessages: + msg258411
2015-12-19 08:55:58serhiy.storchakasetstage: needs patch
2015-09-17 15:46:15zach.warecreate