This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: bring BTPROTO_SCO inline with other Bluetooth protocols
Type: enhancement Stage: needs patch
Components: Extension Modules Versions: Python 3.11
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: Tim.Tisdall, martin.panter
Priority: normal Keywords:

Created on 2015-09-09 15:27 by Tim.Tisdall, last changed 2022-04-11 14:58 by admin.

Messages (3)
msg250316 - (view) Author: Tim Tisdall (Tim.Tisdall) * Date: 2015-09-09 15:27
All of the BTPROTO_ protocols accept tuples with Bluetooth addresses as regular strings.  SCO accepts a byte-string which represents a Bluetooth address.  The change was made at 23ab586c427a 

With the current implementation we get this error:

>>> import socket
>>> x = socket.socket(socket.AF_BLUETOOTH, socket.SOCK_SEQPACKET, socket.BTPROTO_SCO)
>>> x.bind(socket.BDADDR_ANY)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
OSError: getsockaddrarg: wrong format

This is because socket.BDADDR_ANY is a string while the bind() is expecting a binary string.  So the workaround would be to call x.bind(socket.BDADDR_ANY.encode()) .

Is it acceptable to change it to accept a regular string to match the other address methods and constants?  This would be essentially a breaking change, however on something that wasn't really documented prior to #24984 .

I'll submit a patch when the repo is back up...
msg250340 - (view) Author: Martin Panter (martin.panter) * (Python committer) Date: 2015-09-09 23:07
Perhaps making it accept both bytes and text strings is a sensible option. Similar to how AF_INET can bind to both "localhost" and b"localhost".
msg250372 - (view) Author: Tim Tisdall (Tim.Tisdall) * Date: 2015-09-10 13:36
Yes, then any existing implementations will continue to work.

One sticky issue with all of this... there's no existing tests as per #7687 .
History
Date User Action Args
2022-04-11 14:58:20adminsetgithub: 69232
2021-12-27 02:36:57ajaksu2setversions: + Python 3.11, - Python 3.4, Python 3.5, Python 3.6
2015-09-10 13:36:29Tim.Tisdallsetmessages: + msg250372
2015-09-09 23:07:10martin.pantersetnosy: + martin.panter

messages: + msg250340
stage: needs patch
2015-09-09 15:27:52Tim.Tisdallsetcomponents: + Extension Modules
2015-09-09 15:27:22Tim.Tisdallcreate