Usages of the md5 module could be fixed, as it's unavailable in 3k.

In particular:

import md5 -> import hashlib
md5.new(...) -> hashlib.md5(...)
md5.md5(...) -> hashlib.md5(...)

Notice that users could already change this manually in 2.6, since
hashlib is available since 2.5, so the fixer is not strictly needed, but
would be convenient.

And do the same for:

sha.sha1 -> hashlib.sha1
sha.new  -> hashlib.sha1

Attached a patch that provides a (sha | md5) -> hashlib fixer, covering test cases, and updated documentation.

The patch looks clean to me although I don't feel qualified to comment on the technical aspects.  I've tested it on Windows Vista 32 bit against the 2.7 and 3.1 maintainance releases and py3k.  The 2.7 run was fine, both 3.x runs failed.

  File "c:\release31-maint\lib\lib2to3\fixes\fix_hash.py", line 27
    "md5": u"md5",
                ^
SyntaxError: invalid syntax

I've stared at the code until I'm blue in the face and can't see what's wrong, I'm sure someone else will spot the problem in seconds.

I also noticed a small typo in the rst file "modules where deprecated"
should read "modules were deprecated".

The 'u' prefix went away in Python 3, use an unadorned '' or "" for a unicode value.

$ python3
Python 3.1.2 (r312:79147, May 25 2010, 12:21:57) 
[GCC 4.4.3 20100422 (Red Hat 4.4.3-18)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> u"foo"
  File "<stdin>", line 1
    u"foo"
         ^
SyntaxError: invalid syntax

I've successfully rerun the tests for 3.x having stripped the 'u' prefix.

Can this be committed please.  In msg110796 I over-emphasised the technical aspects, the patch is actually against 2to3.

Minor nit: I suggest naming the fixer fix_hashlib, since the name fix_hash could easily be understood as something fixing __hash__ (even if such a fix is impossible for a machine to do).

This fix could also go into fix_imports, but it’s useful as a standalone fixer e.g. to run on code that drops <2.5 compatibility.

What's the status of this?

I haven't touched the patch since I attached it.  I will refresh it today with the feedback given.

Attached is a refreshed patch that works for all active branches.  The only real change from the original is Éric's suggestion to s/hash/hashlib/.  The 'u' prefix isn't an issue any longer because of PEP 414.

Benjamin, does the attached look OK to you?  If so, then I will commit it.

I'm not sure how much this is needed considering hashlib has been around, since 2.5. I hope people aren't having to port from before then.

> I'm not sure how much this is needed considering hashlib has been around, since 2.5.
> I hope people aren't having to port from before then.

Martin alluded to that when he opened the issue saying this wasn't necessary, but a nice
to have.  However, it has been over four years since the issue was opened.  Maybe it
should just be closed.  I don't really have an opinion either way.

Martin, are you still interested in this?

Any code conversion is useful. This will help with old libraries and is
even good for just updating old 2.4 code to 2.7 best practices.

The issue is already fixed. Python 3.7+ no longer import the md5 module directly.