This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: build.bat -e shouldn't also build
Type: behavior Stage: resolved
Components: Windows Versions: Python 3.5
Status: closed Resolution: not a bug
Dependencies: Superseder:
Assigned To: Nosy List: steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2015-04-03 08:33 by tim.golden, last changed 2022-04-11 14:58 by admin. This issue is now closed.

File name Uploaded Description Edit
build-externals.patch tim.golden, 2015-04-03 08:33 review
Messages (3)
msg239957 - (view) Author: Tim Golden (tim.golden) * (Python committer) Date: 2015-04-03 08:33
PCBuild\build.bat takes an argument of -e to pull in external libraries. 

Either by accident or by design the main build will run in addition. However if you'd run pcbuild -e simply to pull in externals, you might not have specified extra build params, such as -d or -p x64.

The attached patch naively drops out after get_externals has been called; other possibilities might include carrying on if -e was not the only parameter.
msg239993 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2015-04-03 13:41
> Either by accident or by design the main build will run in addition.

By design; I intended get_externals.bat to be run explicitly if you just
wanted to pull the externals.
msg240024 - (view) Author: Tim Golden (tim.golden) * (Python committer) Date: 2015-04-03 18:41
Fair enough
Date User Action Args
2022-04-11 14:58:15adminsetgithub: 68044
2015-04-03 18:41:01tim.goldensetstatus: open -> closed
resolution: not a bug
messages: + msg240024

stage: patch review -> resolved
2015-04-03 13:41:34zach.waresetmessages: + msg239993
2015-04-03 08:33:46tim.goldencreate