classification
Title: Use of file.xreadlines() should raise a Py3K warning
Type: Stage:
Components: Interpreter Core Versions: Python 2.6
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: brett.cannon, douglas, georg.brandl
Priority: critical Keywords: 26backport, patch

Created on 2008-03-17 19:28 by brett.cannon, last changed 2008-05-17 22:13 by georg.brandl. This issue is now closed.

Files
File name Uploaded Description Edit
issue2353.patch douglas, 2008-03-17 22:35 fileobject.c patch
Messages (5)
msg63724 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2008-03-17 19:28
Using file.xreadlines() should raise a Py3K warning.
msg63772 - (view) Author: Douglas Mayle (douglas) * Date: 2008-03-17 20:59
I'm on it...
msg63794 - (view) Author: Douglas Mayle (douglas) * Date: 2008-03-17 22:35
Since file() is removed from 3k, this error message tries to be as
generic as possible.  We should also warn on any use of file() instead
of open()
Also, all tests have passed except test_normalization
msg63795 - (view) Author: Douglas Mayle (douglas) * Date: 2008-03-17 22:36
I should note that test_normalization fails with or without the patch,
so no change
msg67017 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2008-05-17 22:13
Committed slightly reviewed patch and test in r63340.
History
Date User Action Args
2008-05-17 22:13:16georg.brandlsetstatus: open -> closed
resolution: accepted
messages: + msg67017
nosy: + georg.brandl
2008-03-17 22:36:14douglassetmessages: + msg63795
2008-03-17 22:35:02douglassetfiles: + issue2353.patch
keywords: + patch
messages: + msg63794
2008-03-17 20:59:42douglassetnosy: + douglas
messages: + msg63772
2008-03-17 20:15:10brett.cannonsetpriority: release blocker -> critical
2008-03-17 19:28:59brett.cannoncreate