classification
Title: TimedRotatingFileHandler does not account for daylight savings time
Type: behavior Stage:
Components: Library (Lib) Versions: Python 2.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: vinay.sajip Nosy List: ceder, vinay.sajip
Priority: normal Keywords:

Created on 2008-03-17 08:00 by ceder, last changed 2008-04-02 21:13 by vinay.sajip. This issue is now closed.

Messages (2)
msg63622 - (view) Author: Per Cederqvist (ceder) Date: 2008-03-17 08:00
If TimedRotatingFileHandler is instructed to roll over the log at
midnight or on a certain weekday, it needs to consider when daylight
savings time starts and ends. The current code just blindly adds
self.interval to self.rolloverAt, totally ignoring that sometimes it
should add 23 or 25 hours instead of 24 hours.

(I suspect that the implementation would be simpler if you use the
datetime module, rather than attempt to patch the existing code.)
msg64881 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2008-04-02 21:13
Updated SVN, but not backported to 2.5 or earlier maintenance branches.
History
Date User Action Args
2008-04-02 21:13:27vinay.sajipsetstatus: open -> closed
resolution: fixed
messages: + msg64881
2008-03-17 19:26:31georg.brandlsetassignee: vinay.sajip
nosy: + vinay.sajip
2008-03-17 08:00:05cedercreate