This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Clean up turtle TPen class
Type: enhancement Stage: resolved
Components: Library (Lib) Versions: Python 3.5
Status: closed Resolution: remind
Dependencies: Superseder:
Assigned To: Nosy List: ezio.melotti, ingrid, jesstess, willingc
Priority: normal Keywords: patch

Created on 2014-07-09 02:46 by ingrid, last changed 2022-04-11 14:58 by admin. This issue is now closed.

File name Uploaded Description Edit
TPen_cleanup.patch ingrid, 2014-07-09 02:46 review
Messages (4)
msg222598 - (view) Author: (ingrid) * Date: 2014-07-09 02:46
There are a lot of methods in the TPen class that are defined but not used because all the child classes overwrite almost all the functions and TPen itself isn't used directly a whole lot. This patch removes the unused code so it's less confusing to read
msg222859 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2014-07-12 17:35
While TPen doesn't seem to be documented, it's not prefixed by a '_', so there might people using it and relying on these methods.
msg223295 - (view) Author: (ingrid) * Date: 2014-07-16 23:12
Ah, I think I was mistaken about some things when I made the first patch but it looks like TPen have a few methods that don't work as you'd expect. Since _colorstr isn't implemented on TPen fillcolor and pencolor pen don't work as intended when you call them directly from TPen. Jesstess suggested raising a NotImplementedError on these functions. Would that be a good change to make?
msg319745 - (view) Author: Carol Willing (willingc) * (Python committer) Date: 2018-06-16 15:03
Hi ingrid,

Thanks for your work on this issue.

I'm triaging the open "turtle" issues, and I'm going to go ahead and close this one. If you would like to open a new, more specific issue, I would welcome that. Thanks.
Date User Action Args
2022-04-11 14:58:05adminsetgithub: 66140
2018-06-16 15:03:14willingcsetstatus: open -> closed

nosy: + willingc
messages: + msg319745

resolution: remind
stage: resolved
2014-07-16 23:12:15ingridsetmessages: + msg223295
2014-07-12 17:35:22ezio.melottisetnosy: + ezio.melotti
messages: + msg222859
2014-07-09 02:46:29ingridcreate