This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_sre.py fails on Win64 because PyOS_CheckStack *never* f
Type: Stage:
Components: Interpreter Core Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: tmick Nosy List: effbot, tmick
Priority: normal Keywords:

Created on 2000-10-10 16:51 by tmick, last changed 2022-04-10 16:02 by admin. This issue is now closed.

Messages (3)
msg1987 - (view) Author: Trent Mick (tmick) (Python triager) Date: 2000-10-10 16:51
There is a small thread on python-dev discussing this:

   http://www.python.org/pipermail/python-dev/2000-October/016455.html

Basically I found that PyOS_CheckStack does not fire as expected on Win64. Looking into this more I got frustrated with PyOS_CheckStack's behaviour on *Win32*. There is a simple workaround (the existing RECURSION_LIMIT framework) that could simply be turned on to ensure that test_[s]re.py run for Python 2.0. The PyOS_CheckStack behavious on Win64 can be figured out when it become more mainstream.

The proposed fix is:

*** Include\pythonrun.h~     Wed Oct 04 14:18:00 2000
--- Include\pythonrun.h      Wed Oct 04 13:17:17 2000
***************
*** 88,94 ****
     to a 8k margin. */
  #define PYOS_STACK_MARGIN 2048

! #if defined(WIN32) && defined(_MSC_VER)
  /* Enable stack checking under Microsoft C */
  #define USE_STACKCHECK
  #endif
--- 88,94 ----
     to a 8k margin. */
  #define PYOS_STACK_MARGIN 2048

! #if defined(WIN32) && !defined(MS_WIN64) && defined(_MSC_VER)
  /* Enable stack checking under Microsoft C */
  #define USE_STACKCHECK
  #endif


msg1988 - (view) Author: Fredrik Lundh (effbot) * (Python committer) Date: 2000-10-11 10:56
Looks like this is the only reasonable thing to do
before 2.0 final.  Can you check it in?

</F>
msg1989 - (view) Author: Trent Mick (tmick) (Python triager) Date: 2000-10-11 17:31
Okay, I checked in the suggested patch
History
Date User Action Args
2022-04-10 16:02:30adminsetgithub: 33325
2000-10-10 16:51:02tmickcreate