classification
Title: Declaration of EVP_MD_CTX causes crash when switching between OpenSSL 0.9 and 1.0
Type: crash Stage: resolved
Components: Extension Modules Versions: Python 3.4, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Ryan.Calhoun, christian.heimes, gregory.p.smith, iritkatriel
Priority: normal Keywords: patch

Created on 2014-05-23 20:45 by Ryan.Calhoun, last changed 2020-11-25 21:09 by christian.heimes. This issue is now closed.

Files
File name Uploaded Description Edit
EVP_MD_CTX-python3.4.patch Ryan.Calhoun, 2014-05-23 20:45 Patch for _hashlib.c to change EVP_MD_CTX declaration
Messages (3)
msg218995 - (view) Author: Ryan Calhoun (Ryan.Calhoun) * Date: 2014-05-23 20:45
OpenSSL, specifically libcrypto, includes functions EVP_MD_CTX_create() and EVP_MD_CTX_destroy(), such that the application code only needs to forward declare the EVP_MD_CTX* pointer type.

Declaring the EVP_MD_CTX variable type directly requires compile-time knowledge of the size of the structure. This knowledge will be wrong when compiling with headers from OpenSSL 0.9.8 and dynamically linking at run time against OpenSSL 1.0.1. Result is a SIGSEGV as follows:

(gdb) bt
#0  0x00007ffff03b71a0 in EVP_PKEY_CTX_dup () from /usr/lib64/libcrypto.so
#1  0x00007ffff03a90cd in EVP_MD_CTX_copy_ex () from /usr/lib64/libcrypto.so
#2  0x00007ffff110da8a in EVPnew (name_obj=0x7ffff7ef45a8, digest=0x0, initial_ctx=0x7ffff130fbc0, cp=0x0, len=0)
    at /home/ryan/vaas/python/2.7.6/build/src/Python-2.7.6/Modules/_hashopenssl.c:436
#3  0x00007ffff110de10 in EVP_new_md5 (self=<value optimized out>, args=<value optimized out>)
    at /home/ryan/vaas/python/2.7.6/build/src/Python-2.7.6/Modules/_hashopenssl.c:540

The attached patch updates all declarations in _hashopenssl.c to be pointers initialized by calling EVP_MD_CTX_create(). The patch is done against source version 3.4.1. I have a similar patch for version 2.7.6, but can only attach one file here?
msg381858 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2020-11-25 19:31
This patch is out of date with the code, but comparing it with the code I think the fixes were made. Christian, can you confirm?
msg381863 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2020-11-25 21:09
The code has changed a lot since this bug was opened. It's no longer an issue. Thanks for checking!
History
Date User Action Args
2020-11-25 21:09:33christian.heimessetstatus: pending -> closed
resolution: out of date -> fixed
messages: + msg381863

stage: resolved
2020-11-25 19:31:01iritkatrielsetstatus: open -> pending

nosy: + iritkatriel
messages: + msg381858

resolution: out of date
2014-05-23 21:14:02pitrousetnosy: + gregory.p.smith, christian.heimes
2014-05-23 20:45:51Ryan.Calhouncreate