classification
Title: 3.4 cherry-pick: bf413a97f1a9 fix conflicting hypot definition with VS 2010
Type: behavior Stage:
Components: Build, Windows Versions: Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: larry Nosy List: larry, zach.ware
Priority: release blocker Keywords:

Created on 2014-02-20 21:56 by zach.ware, last changed 2014-02-20 23:30 by larry. This issue is now closed.

Messages (2)
msg211756 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2014-02-20 21:56
PC/pyconfig.h does "#define hypot _hypot", but VS 2010 and above already define a hypot function (implemented by _hypot), which results in a warning if you have warning 4211 enabled (which warning level 4 does) or a recursive definition which results in a crash at runtime, depending on how you use Python.h.  Python itself doesn't suffer from the runtime crash, but Blender does because of Python.

bf413a97f1a9 fixes it by guarding the #define with #if _MSC_VER < 1600.

This one is kind of borderline for RC phase in my mind, so I leave it up to you to decide, Larry.  It is a serious issue for at least Blender and one other extension author.  On the other hand, this issue has been around since 3.3.0 (the first VS 2010-supporting release) and was only reported this January.
msg211763 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2014-02-20 23:30
ok.  it's a low-risk fix.
History
Date User Action Args
2014-02-20 23:30:59larrysetstatus: open -> closed
resolution: fixed
2014-02-20 23:30:46larrysetmessages: + msg211763
2014-02-20 21:56:14zach.warecreate