classification
Title: 3.4 cherry-pick: eef7899ea7ab use system doc toolchain instead of checking out of svn
Type: Stage:
Components: Versions: Python 3.4
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: larry Nosy List: georg.brandl, larry, loewis, ned.deily
Priority: release blocker Keywords:

Created on 2014-02-17 16:35 by georg.brandl, last changed 2014-02-18 10:01 by ned.deily. This issue is now closed.

Messages (10)
msg211423 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2014-02-17 16:35
3.4 cherry-pick: eef7899ea7ab use system doc toolchain instead of checking out of svn
msg211443 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2014-02-17 21:29
Okay.  I'll do the first round of cherry-picking Tuesday or Wednesday (my time).  I'm waiting for the list of requests to settle down so I can do them in chronological order.
msg211453 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2014-02-17 23:10
Georg, why do you want to cherry-pick this for 3.4.0?  As noted in Issue20644, it definitely breaks OS installer builds and it may break Windows installer builds as well.  We would need to address those problems as wee before rc2, which seems to me to make this out of scope for a release candidate fix.  I would prefer to see this deferred to 3.4.1.
msg211479 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2014-02-18 07:46
Well, I thought the installer script can surely be fixed in time.  If not, I agree that this shouldn't be picked yet.
msg211480 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2014-02-18 08:13
The installer script wasn't broken, neither was the dmg buildbot.  I'm still not seeing how this change qualifies as one that should be allowed in after rc1.  Perhaps if there were a bug tracker issue that justified it.  Still I'll see what I can do to implement the needed changes in the installer script included in the release and in the behind the scenes build process in time.  As long as Python 2.5 can still be used for sphinx-build for now, it shouldn't be too bad.
msg211482 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2014-02-18 08:17
Also Martin should give his blessing wrt the Windows installer builds.
msg211488 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2014-02-18 08:29
The change was requested by doko for Debian/Ubuntu.  As for changing it after rc1, I agree it is unfortunate.  But it doesn't affect the distributed content, only how the release is built, which I think is exactly what *can* go in the rc phase.

The Python requirement didn't change, you "just" have to have the toolchain lying around somewhere.
msg211494 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2014-02-18 08:42
It does affect the distributed content in that the installer scripts for OS X and Windows are part of the source release and both Martin and I try very hard to build installers from unmodified source.  And the OS X installers are built from a known vanilla environment each time which will now have to change.  And I believe at least some third-party packagers use our installer build scripts as a basis for their own installer builds.  So for all those reasons I think in an ideal world it's not appropriate for rc2 inclusion.  But let's see what Martin says and I'll go with Larry's call.
msg211495 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2014-02-18 08:54
I see.  I don't want to make your life miserable, so let's make a compromise and keep it for 3.4.1, and Debian will have to patch it locally for 3.4.0.
msg211505 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2014-02-18 10:01
Thanks, Georg.
History
Date User Action Args
2014-02-18 10:01:38ned.deilysetmessages: + msg211505
2014-02-18 08:54:00georg.brandlsetstatus: open -> closed
resolution: rejected
messages: + msg211495
2014-02-18 08:42:39ned.deilysetmessages: + msg211494
2014-02-18 08:29:45georg.brandlsetmessages: + msg211488
2014-02-18 08:17:56ned.deilysetnosy: + loewis
messages: + msg211482
2014-02-18 08:13:24ned.deilysetmessages: + msg211480
2014-02-18 07:46:52georg.brandlsetmessages: + msg211479
2014-02-17 23:10:10ned.deilysetnosy: + ned.deily
messages: + msg211453
2014-02-17 21:29:17larrysetmessages: + msg211443
2014-02-17 16:35:57georg.brandlcreate