classification
Title: improve bytes and bytearray tests
Type: enhancement Stage:
Components: Tests Versions: Python 3.0
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: christian.heimes, pitrou
Priority: normal Keywords: patch

Created on 2008-01-30 10:57 by pitrou, last changed 2008-01-30 11:58 by christian.heimes. This issue is now closed.

Files
File name Uploaded Description Edit
bytestest.patch pitrou, 2008-01-30 10:57
bytestest.patch pitrou, 2008-01-30 11:47
bytestest.patch pitrou, 2008-01-30 11:57 updated patch without workaround for fixed bytes.fromhex bug
Messages (5)
msg61854 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2008-01-30 10:57
Currently some tests in test_bytes.py only test bytearray, others only
test bytes. Here is a patch to try to make test coverage more extensive.
You'll notice there is a small hack in test_fromhex, that's because
bytes.fromhex is buggy, I'll open a separate bug entry for that.
msg61859 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2008-01-30 11:26
Good idea but could you please use typ2test instead of a decorator? It
involves too much magic.
msg61863 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2008-01-30 11:47
Ok, here is a patch using type2test instead :)
msg61864 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2008-01-30 11:48
Hmm, that "import functools" at top of the file certainly can be removed...
msg61865 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2008-01-30 11:58
Thanks again! Applied in r60442
History
Date User Action Args
2008-01-30 11:58:34christian.heimessetstatus: open -> closed
resolution: accepted -> fixed
messages: + msg61865
2008-01-30 11:57:52pitrousetfiles: + bytestest.patch
2008-01-30 11:48:50pitrousetmessages: + msg61864
2008-01-30 11:47:08pitrousetfiles: + bytestest.patch
messages: + msg61863
2008-01-30 11:26:22christian.heimessetnosy: + christian.heimes
messages: + msg61859
priority: normal
type: enhancement
keywords: + patch
resolution: accepted
2008-01-30 10:57:03pitroucreate