This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: mingw: configure MACHDEP and platform for build
Type: enhancement Stage: resolved
Components: Build, Cross-Build Versions: Python 3.4
process
Status: closed Resolution: duplicate
Dependencies: Superseder:
Assigned To: Nosy List: martin.panter, rpetrov
Priority: normal Keywords: patch

Created on 2013-03-31 19:43 by rpetrov, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
0004-MINGW-configure-MACHDEP-and-platform-for-build.patch rpetrov, 2013-03-31 19:43 review
MINGW-MACHDEP.v2.patch martin.panter, 2016-03-12 02:30 review
Messages (3)
msg185650 - (view) Author: Roumen Petrov (rpetrov) * Date: 2013-03-31 19:43
split of issue3871
msg261600 - (view) Author: Martin Panter (martin.panter) * (Python committer) Date: 2016-03-11 21:00
There are some spelling errors in the comments. It would also be good to keep the indentation, quoting, layout etc similar to the surrounding code.

Regarding the comments, what is the significance of “runtime platform” vs MACHDEP? Also, what is the significance of sys.platform() when setting _PYTHON_HOST_PLATFORM?

Why did you use different types of comments? (# vs dnl)

I do not understand the comment “build must not depend from posix-compatible environment”. Is this just explaining that we are setting ac_sys_system (uname -s) to a dummy generic value that will not trigger any special cases. Should we also set ac_sys_release to an empty string, like the cross-compiling case later on?

What’s the go with the two competing “mingw*)” cases when determining _PYTHON_HOST_PLATFORM? What is the situation where $host matches *-*-mingw*, but $host_os does not match mingw*?
msg261632 - (view) Author: Martin Panter (martin.panter) * (Python committer) Date: 2016-03-12 02:30
Here is a modified patch fixing a couple of the spelling & style problems. I moved the comment introducing the ac_sys_ variables up to before the code that sets them. I rearranged the logic for _PYTHON_HOST_PLATFORM so it is clear that $host_os overrides $host, and I combined the cygwin and mingw cases.

I suspect the configure.ac logic could be simplified more.
History
Date User Action Args
2022-04-11 14:57:43adminsetgithub: 61792
2021-10-20 12:42:30iritkatrielsetstatus: open -> closed
resolution: duplicate
stage: patch review -> resolved
2016-03-12 02:30:08martin.pantersetfiles: + MINGW-MACHDEP.v2.patch

messages: + msg261632
2016-03-11 21:04:42martin.panterlinkissue17605 dependencies
2016-03-11 21:00:55martin.pantersetnosy: + martin.panter

messages: + msg261600
stage: patch review
2013-03-31 19:43:30rpetrovcreate