This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Distutils ignore dry-run flag at clean-up of distutils.command.build_scripts.copy_scripts
Type: crash Stage:
Components: Distutils Versions: Python 2.5
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: gvanrossum Nosy List: gvanrossum, ludvig.ericson
Priority: normal Keywords: patch

Created on 2007-12-25 03:56 by ludvig.ericson, last changed 2022-04-11 14:56 by admin. This issue is now closed.

File name Uploaded Description Edit
distutils.diff gvanrossum, 2008-01-02 03:45
Messages (8)
msg58988 - (view) Author: toxik (ludvig.ericson) Date: 2007-12-25 03:56
It's actually py251.

113             else:
114                 f.close()
115                 self.copy_file(script, outfile)

Earlier, f is set to None if file is not found, and we are in dry-run
mode. Simple solution:

113             elif f:
114                 f.close()
115                 self.copy_file(script, outfile)
msg59084 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2008-01-02 03:45
Actually, only the f.close() call should be conditionalized.
Does this patch fix the issue for you?
msg59088 - (view) Author: toxik (ludvig.ericson) Date: 2008-01-02 04:22
It doesn't die now, but AFAICT, it doesn't even try to copy the script
now. (With your patch.)

I might also add that this is for package_data.
msg59097 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2008-01-02 17:44
I'm not a big distutils expert myself, I can't quite interpret your
feedback. In dry-run mode, it shouldn't try to copy the script, correct?
msg59099 - (view) Author: toxik (ludvig.ericson) Date: 2008-01-02 17:45
It shouldn't try to copy the script anywhere, it should just tell me
what it was going to do, by means of console.
msg59100 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2008-01-02 18:28
So that's correct behavior right?  (I looked at the code for copy_file()
in and it passes the dry_run parameter to the file utility
function that does the actual copying.
msg59101 - (view) Author: toxik (ludvig.ericson) Date: 2008-01-02 18:32
Mmh, well, as far as I could tell when I tested your patch, it didn't
say it's going to copy the file, but it didn't say it isn't going to either.

As far as this ticket is concerned however, I'd say the behavior is now
msg59103 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2008-01-02 19:01
Committed revision 59668.  (2.5 branch)
Committed revision 59669.  (2.6 trunk)
Date User Action Args
2022-04-11 14:56:29adminsetgithub: 46037
2008-01-02 19:01:05gvanrossumsetstatus: open -> closed
resolution: fixed
messages: + msg59103
2008-01-02 18:32:02ludvig.ericsonsetmessages: + msg59101
2008-01-02 18:28:44gvanrossumsetmessages: + msg59100
2008-01-02 17:45:12ludvig.ericsonsetmessages: + msg59099
2008-01-02 17:44:16gvanrossumsetkeywords: + patch
messages: + msg59097
2008-01-02 04:22:39ludvig.ericsonsetmessages: + msg59088
2008-01-02 03:45:52gvanrossumsetpriority: normal
assignee: gvanrossum
messages: + msg59084
files: + distutils.diff
nosy: + gvanrossum
2007-12-25 03:56:15ludvig.ericsoncreate