This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Port Python/import.c to py3k branch
Type: crash Stage:
Components: Interpreter Core Versions: Python 3.0
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ncoghlan Nosy List: christian.heimes, ncoghlan
Priority: high Keywords:

Created on 2007-12-03 21:03 by christian.heimes, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (3)
msg58155 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2007-12-03 21:03
Dear Nick!

I wasn't able to get your modification to Python/import.c from r59288 to
run. Can you please port the files to py3k yourself? Thanks!

msg58183 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2007-12-04 12:27
I should have known that fiddling with import.c couldn't possibly go as
smoothly as it had been ;)

The problem actually turned out to be fairly shallow - the merge picked
up a lot of calls to the PyString_* interfaces from the 2.x import
implementation. Replacing all those calls with the PyUnicode_*
equivalent eliminated the crash.

Fixed in rev 59319.
msg58184 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2007-12-04 12:44

I manually fixed several of the PyString -> PyUnicode differences but it
didn't work for me. Maybe I missed one or two places. Anyway the main
issue is sovled. :]
Date User Action Args
2022-04-11 14:56:28adminsetgithub: 45892
2008-01-06 22:29:44adminsetkeywords: - py3k
versions: Python 3.0
2007-12-04 12:44:26christian.heimessetmessages: + msg58184
2007-12-04 12:27:17ncoghlansetstatus: open -> closed
type: crash
resolution: fixed
messages: + msg58183
2007-12-03 21:03:50christian.heimescreate