This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: test_collections: failing refleak test
Type: Stage:
Components: Tests Versions: Python 3.0
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: gvanrossum Nosy List: amaury.forgeotdarc, christian.heimes, gvanrossum
Priority: high Keywords:

Created on 2007-12-02 14:37 by christian.heimes, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (3)
msg58088 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2007-12-02 14:37
The refleak tests of test_collections are broken. I fear that my changes
to have cause the problem but I don't understand why it's
broken. Can you have a look please?
msg58210 - (view) Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) Date: 2007-12-05 09:26
I found indeed 2 problems in
I don't have svn access for the moment, so I cannot provide a regular
patch, so here are the changes:

- The line
    obj._abc_registry = abcs.get(obj, {}).copy()
incorrectly puts an empty dictionary in _abc_registry. It should be a set:
    from weakref import WeakSet
    obj._abc_registry = abcs.get(obj, WeakSet()).copy()

- This test in dash_R()
    if not isinstance(abc, _Abstract):
is not correct. It should be 
    if not issubclass(abc, _Abstract):
(Note that dash_R_cleanup contains the same line, but correctly)
msg58212 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2007-12-05 12:46
Fixed in r59349
Good work Amaury! :)
Date User Action Args
2022-04-11 14:56:28adminsetgithub: 45880
2008-01-06 22:29:44adminsetkeywords: - py3k
versions: Python 3.0
2007-12-05 12:46:27christian.heimessetstatus: open -> closed
resolution: fixed
messages: + msg58212
2007-12-05 09:26:14amaury.forgeotdarcsetnosy: + amaury.forgeotdarc
messages: + msg58210
2007-12-05 05:49:26gvanrossumsetpriority: normal -> high
2007-12-02 14:37:25christian.heimescreate