While it's documented that unicode.translate()s table maps ordinals to
strings/ordinals/None, if you give a unicode key in the table it will
just be ignored. This is quite surprising.

Here's a patch that should make unicode.translate() more robust, and
also allows unicode characters to be passed in the mapping.

Nice idea, but why don't you use a dictionary iterator (PyDict_Next())
for the fixup ?

Marc-Andre Lemburg schrieb:
> Marc-Andre Lemburg added the comment:
> 
> Nice idea, but why don't you use a dictionary iterator (PyDict_Next())
> for the fixup ?

I thought that is unsafe to use when the dictionary is mutated while
iterating.

Ah, I hadn't noticed that you're actually manipulating the input
dictionary. You should create a copy and fix that instead of changing
the dict that the user passed in to the function.

You can then use PyDict_Next() for fast iteration over the original
dictionary.

Yes, that makes sense.
New patch attached, copying the dict and using PyDict_Next.

Committed to Py3k as r58603.