This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author r.david.murray
Recipients georg.brandl, r.david.murray
Date 2010-02-11.03:13:59
SpamBayes Score 3.5822845e-06
Marked as misclassified No
Message-id <1265858045.44.0.437187909795.issue7905@psf.upfronthosting.co.za>
In-reply-to
Content
While working on another shelve issue I noticed that the keyencoding keyword argument was added to shelf, but that the value is hardcoded to 'utf-8' in the __init__ body.  DbfilenameShelf does not have a keyencoding option, nor does open, but BsdDbShelf does.  It seems to me that keyencoding was intended to be exposed but the work was not completed.  However I could be wrong...in which case the module should probably just use sys.getdefaultencoding.

I've prepared a patch that fixes the hardcoding bug and adds docs for the places where the keyword argument is currently accepted.  If this argument is kept and is documented, it should presumably be added to DbfilenameShelf and open as well.
History
Date User Action Args
2010-02-11 03:14:05r.david.murraysetrecipients: + r.david.murray, georg.brandl
2010-02-11 03:14:05r.david.murraysetmessageid: <1265858045.44.0.437187909795.issue7905@psf.upfronthosting.co.za>
2010-02-11 03:14:03r.david.murraylinkissue7905 messages
2010-02-11 03:14:02r.david.murraycreate