This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author giampaolo.rodola
Recipients giampaolo.rodola, pitrou, vstinner
Date 2009-12-31.14:25:38
SpamBayes Score 5.16351e-09
Marked as misclassified No
Message-id <1262269542.1.0.738880203371.issue4814@psf.upfronthosting.co.za>
In-reply-to
Content
This time it's not easy as I see no way to distinguish whether the 
timeout exception gets raised by the command or the control socket, as 
makeport() method implementation deals with both:

<snippet>
        host = self.sock.getsockname()[0] 
        if self.af == socket.AF_INET:
            resp = self.sendport(host, port)  # socket.timeout can be 
raised here
        else:
            resp = self.sendeprt(host, port)   # ...here
        if self.timeout is not _GLOBAL_DEFAULT_TIMEOUT:
            sock.settimeout(self.timeout)    # or here
</snippet>

I think the best we can do is add a test which checks the timeout 
applied to the data socket resulting from a PASV/PORT request.
That doesn't cover this specific bug at all but it's something which is 
currently missing and that it would be nice to have.
History
Date User Action Args
2009-12-31 14:25:42giampaolo.rodolasetrecipients: + giampaolo.rodola, pitrou, vstinner
2009-12-31 14:25:42giampaolo.rodolasetmessageid: <1262269542.1.0.738880203371.issue4814@psf.upfronthosting.co.za>
2009-12-31 14:25:39giampaolo.rodolalinkissue4814 messages
2009-12-31 14:25:38giampaolo.rodolacreate