Message 96802 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	sh
Recipients	sh, skrah
Date	2009-12-22.17:33:34
SpamBayes Score	9.213078e-05
Marked as misclassified	No
Message-id	<1261503216.62.0.587696279501.issue7561@psf.upfronthosting.co.za>
In-reply-to

Content
You're correct about PyUnicode_FSConverter(), which is why the very first part of my patch fixes that function. Only fixing that one will get rid of the segfaults, but also lead to incorrect error reporting for the zero-length bytearray case; the bytes2str() modification is to get the right exceptions. I don't know which precise semantics PyByteArray_AS_STRING() is supposed to have. I assumed it returning NULL was normal for 0-byte-length arrays, and based my patch off of that.

You're correct about PyUnicode_FSConverter(), which is why the very
first part of my patch fixes that function. Only fixing that one will
get rid of the segfaults, but also lead to incorrect error reporting for
the zero-length bytearray case; the bytes2str() modification is to get
the right exceptions.

I don't know which precise semantics PyByteArray_AS_STRING() is
*supposed* to have. I assumed it returning NULL was normal for
0-byte-length arrays, and based my patch off of that.

History
Date	User	Action	Args
2009-12-22 17:33:36	sh	set	recipients: + sh, skrah
2009-12-22 17:33:36	sh	set	messageid: <1261503216.62.0.587696279501.issue7561@psf.upfronthosting.co.za>
2009-12-22 17:33:35	sh	link	issue7561 messages
2009-12-22 17:33:34	sh	create