Message93767
I'll leave it to Vinay to pronounce on the request and the validity of
the patch, but a couple of comments on the mechanics of the patch: You
have some rogue whitespace on one of the blank lines. More importantly,
you are adding a keyword parameter at the beginning of the list of
keywords, which would change the semantics if someone passed in
arguments positionally. Finally, you should check out PEP 8 about
Python style...the line length should be less the 80, which means your
docstring addition needs to be reformatted, as well as the __init__ line
itself.
Thanks for contributing!
Oh, and while I set the stage to test needed it doesn't look like there
are any existing tests for SysLogHandler.... |
|
Date |
User |
Action |
Args |
2009-10-09 00:11:56 | r.david.murray | set | recipients:
+ r.david.murray, vinay.sajip, enigma |
2009-10-09 00:11:56 | r.david.murray | set | messageid: <1255047116.22.0.0831727759926.issue7086@psf.upfronthosting.co.za> |
2009-10-09 00:11:53 | r.david.murray | link | issue7086 messages |
2009-10-09 00:11:51 | r.david.murray | create | |
|