This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author r.david.murray
Recipients enigma, r.david.murray, vinay.sajip
Date 2009-10-09.00:11:51
SpamBayes Score 6.760761e-08
Marked as misclassified No
Message-id <1255047116.22.0.0831727759926.issue7086@psf.upfronthosting.co.za>
In-reply-to
Content
I'll leave it to Vinay to pronounce on the request and the validity of
the patch, but a couple of comments on the mechanics of the patch:  You
have some rogue whitespace on one of the blank lines.  More importantly,
you are adding a keyword parameter at the beginning of the list of
keywords, which would change the semantics if someone passed in
arguments positionally.  Finally, you should check out PEP 8 about
Python style...the line length should be less the 80, which means your
docstring addition needs to be reformatted, as well as the __init__ line
itself.

Thanks for contributing!

Oh, and while I set the stage to test needed it doesn't look like there
are any existing tests for SysLogHandler....
History
Date User Action Args
2009-10-09 00:11:56r.david.murraysetrecipients: + r.david.murray, vinay.sajip, enigma
2009-10-09 00:11:56r.david.murraysetmessageid: <1255047116.22.0.0831727759926.issue7086@psf.upfronthosting.co.za>
2009-10-09 00:11:53r.david.murraylinkissue7086 messages
2009-10-09 00:11:51r.david.murraycreate