Message 91987 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	agillesp
Recipients	agillesp, r.david.murray, ryles
Date	2009-08-26.22:43:59
SpamBayes Score	3.2105646e-08
Marked as misclassified	No
Message-id	<1251326642.55.0.183387208504.issue6759@psf.upfronthosting.co.za>
In-reply-to

Content
Hi David, Thanks for the review. Patch attached. (1) I've moved that comment to the check's new location. (2) Fixed the bug and added tests for only one separator. Also added test data and tests for mixed eol files. (3) I changed this so that when the file is opened with universal newline support, read(size) makes multiple calls to _do_read until size bytes are read or EOF is reached.

Hi David,

Thanks for the review.  Patch attached.

(1)  I've moved that comment to the check's new location.

(2)  Fixed the bug and added tests for only one separator.  Also added
test data and tests for mixed eol files.

(3)  I changed this so that when the file is opened with universal
newline support, read(size) makes multiple calls to _do_read until size
bytes are read or EOF is reached.

History
Date	User	Action	Args
2009-08-26 22:44:02	agillesp	set	recipients: + agillesp, r.david.murray, ryles
2009-08-26 22:44:02	agillesp	set	messageid: <1251326642.55.0.183387208504.issue6759@psf.upfronthosting.co.za>
2009-08-26 22:44:00	agillesp	link	issue6759 messages
2009-08-26 22:44:00	agillesp	create