Message90576
Thanks again, casevh! The patch looks good. I've added to it a bit,
though---see issue6431.patch. In detail:
- don't use subtraction with unknown types for <, <=, >, >=; this is
dangerous, since the unknown type may well do a lossy conversion, and
comparisons should really be exact where possible; as with __eq__,
it seems better to return NotImplemented and give the other type a
chance.
- handle infs and nans correctly in comparisons with floats
- a few more tests.
casevh, please could you have a look at the attached patch and let me
know whether it still works with your gmpy port?
Jeffrey, any comments on these changes? |
|
Date |
User |
Action |
Args |
2009-07-16 18:34:34 | mark.dickinson | set | recipients:
+ mark.dickinson, casevh, jyasskin |
2009-07-16 18:34:33 | mark.dickinson | set | messageid: <1247769273.72.0.0927937922347.issue6431@psf.upfronthosting.co.za> |
2009-07-16 18:34:30 | mark.dickinson | link | issue6431 messages |
2009-07-16 18:34:30 | mark.dickinson | create | |
|