Message 89771 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	amaury.forgeotdarc
Recipients	amaury.forgeotdarc, ocean-city
Date	2009-06-28.09:47:52
SpamBayes Score	4.7983012e-05
Marked as misclassified	No
Message-id	<1246182474.13.0.59101730474.issue6344@psf.upfronthosting.co.za>
In-reply-to

Content
> + if (n < 0) I suggest a comment like: /* The difference can overflow, only if self->size is greater than * PY_SSIZE_T_MAX. But then the operation cannot possibly succeed, * because the mapped area and the returned string each need more * than half of the addressable memory. So we clip the size, and let * the code below raise MemoryError. */

> +	if (n < 0)

I suggest a comment like:

/* The difference can overflow, only if self->size is greater than
 * PY_SSIZE_T_MAX.  But then the operation cannot possibly succeed,
 * because the mapped area and the returned string each need more 
 * than half of the addressable memory.  So we clip the size, and let
 * the code below raise MemoryError.
 */

History
Date	User	Action	Args
2009-06-28 09:47:54	amaury.forgeotdarc	set	recipients: + amaury.forgeotdarc, ocean-city
2009-06-28 09:47:54	amaury.forgeotdarc	set	messageid: <1246182474.13.0.59101730474.issue6344@psf.upfronthosting.co.za>
2009-06-28 09:47:53	amaury.forgeotdarc	link	issue6344 messages
2009-06-28 09:47:52	amaury.forgeotdarc	create