Message 89648 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	barry
Recipients	JohnJackson, amaury.forgeotdarc, barry, gpolo, kiilerix, zhirsch
Date	2009-06-23.21:51:05
SpamBayes Score	3.1086245e-15
Marked as misclassified	No
Message-id	<1245793866.79.0.531538335338.issue2622@psf.upfronthosting.co.za>
In-reply-to

Content
The patch looks pretty good, except that you should not change test_email.py. It specifically tests the old names, while test_email_renamed.py tests the new names. There's no point in fixing Python 2.5 since there won't be another maintenance release of that version. It probably also does not make sense to change Python 3.x. You should fix Python 2.6 though. In the trunk, we should remove all the old names for good.

The patch looks pretty good, except that you should not change
test_email.py.  It specifically tests the old names, while
test_email_renamed.py tests the new names.

There's no point in fixing Python 2.5 since there won't be another
maintenance release of that version.  It probably also does not make
sense to change Python 3.x.  You should fix Python 2.6 though.

In the trunk, we should remove all the old names for good.

History
Date	User	Action	Args
2009-06-23 21:51:07	barry	set	recipients: + barry, amaury.forgeotdarc, gpolo, kiilerix, JohnJackson, zhirsch
2009-06-23 21:51:06	barry	set	messageid: <1245793866.79.0.531538335338.issue2622@psf.upfronthosting.co.za>
2009-06-23 21:51:05	barry	link	issue2622 messages
2009-06-23 21:51:05	barry	create