Message89376
Some comments about the patch:
- It seems wasteful to allocate a new PyUnicode object for the "."; the
posix implements does it right: a simple wcscopy should be enough (and
reduces the chances of refcount mistakes)
- the last block is not correctly indented; this code uses tabs.
- no need to test for hasattr(posix, 'listdir'): all supported platforms
have directories and the posix module always exposes this function. |
|
Date |
User |
Action |
Args |
2009-06-14 23:12:40 | amaury.forgeotdarc | set | recipients:
+ amaury.forgeotdarc, rhettinger, tarek, vdupras |
2009-06-14 23:12:39 | amaury.forgeotdarc | set | messageid: <1245021159.65.0.997946615632.issue6095@psf.upfronthosting.co.za> |
2009-06-14 23:12:38 | amaury.forgeotdarc | link | issue6095 messages |
2009-06-14 23:12:38 | amaury.forgeotdarc | create | |
|