This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author amaury.forgeotdarc
Recipients amaury.forgeotdarc, rhettinger, tarek, vdupras
Date 2009-06-14.23:12:37
SpamBayes Score 2.0227009e-10
Marked as misclassified No
Message-id <1245021159.65.0.997946615632.issue6095@psf.upfronthosting.co.za>
In-reply-to
Content
Some comments about the patch:

- It seems wasteful to allocate a new PyUnicode object for the "."; the 
posix implements does it right: a simple wcscopy should be enough (and 
reduces the chances of refcount mistakes)

- the last block is not correctly indented; this code uses tabs.

- no need to test for hasattr(posix, 'listdir'): all supported platforms 
have directories and the posix module always exposes this function.
History
Date User Action Args
2009-06-14 23:12:40amaury.forgeotdarcsetrecipients: + amaury.forgeotdarc, rhettinger, tarek, vdupras
2009-06-14 23:12:39amaury.forgeotdarcsetmessageid: <1245021159.65.0.997946615632.issue6095@psf.upfronthosting.co.za>
2009-06-14 23:12:38amaury.forgeotdarclinkissue6095 messages
2009-06-14 23:12:38amaury.forgeotdarccreate