Message87354
Hi Tarek,
I agree that a change in that module is "risky" but a warning won't
solve the main problem in the long run: anyway I'm not able to comment
about the best strategy.
Now the access problem:
If an import logging is put into the log.py the (python) build fails
complaining the missing time module (upon which logging depends): this
happens during the bootstrap phase (the lib-dynload is not in the path
unless changes to the build system).
This is shown in the suse build server where python gets compiled from
scratch without a previously installed python (contrary to what usually
happen on a normal system).
Attached there's the build error using a minimal log.py (susebuild.log).
About my patch:
- removed the raise
- now it catches only the ImportError
- The Logger.stream (as the _log) is a "static" and it should really
belong to all the classes not a particular instance: anyway
this is used just during the bootstrap so it needs to provide
a bare minimum support;)
- INFO/DEBUG/etc are defined there because they're not
used during the bootstrap (correctly, IMHO). If I had no fear
to break the other modules I'd removed them from there as well:
I haven't seen them used elsewhere.
PS. I'm waiting for the build to complete in order to confirm if
everything works fine. |
|
Date |
User |
Action |
Args |
2009-05-07 01:05:45 | cavallo71 | set | recipients:
+ cavallo71, christian.heimes, tarek, akitada |
2009-05-07 01:05:44 | cavallo71 | set | messageid: <1241658344.83.0.890227143856.issue3992@psf.upfronthosting.co.za> |
2009-05-07 01:05:43 | cavallo71 | link | issue3992 messages |
2009-05-07 01:05:41 | cavallo71 | create | |
|