Message84794
The patch looks all right in general. I would use something like
if "poll" in dir(select)
instead of catching AttributeError which risks hiding bugs in
_communicate_with_poll().
PEP8 probably wants spaces around the bitwise-or operator.
Some systems cannot use TTYs in poll(2) but this should not be a
problem here - there is no point in using .communicate() with stdin/
stdout/stderr set to anything but PIPE, right? |
|
Date |
User |
Action |
Args |
2009-03-31 15:00:49 | yorick | set | recipients:
+ yorick, gregory.p.smith, mkc, d_kagedal, fpmc |
2009-03-31 15:00:49 | yorick | set | messageid: <1238511649.1.0.831730615213.issue3392@psf.upfronthosting.co.za> |
2009-03-31 15:00:47 | yorick | link | issue3392 messages |
2009-03-31 15:00:47 | yorick | create | |
|