Message84376
> I'm still not sure why anyone would care about getting longs
> instead of ints back from int(x)
It's strange that sometimes we need to write int(int(obj)) to get an
integer :-/ I usually use int(x) to convert x to an integer (type 'int'
and not 'long').
> (0) Please could you add some tests!
done
> (1) Shouldn't the first line you added include a check
> for res == NULL?
segfault... ooops :-) fixed
> (2) It looks as though the patched code ends up calling
> PyLong_Check twice (...)
done
See updated patch. |
|
Date |
User |
Action |
Args |
2009-03-29 11:38:43 | vstinner | set | recipients:
+ vstinner, rhettinger, terry.reedy, mark.dickinson, debedb |
2009-03-29 11:38:43 | vstinner | set | messageid: <1238326723.54.0.306166260793.issue5377@psf.upfronthosting.co.za> |
2009-03-29 11:38:42 | vstinner | link | issue5377 messages |
2009-03-29 11:38:41 | vstinner | create | |
|