This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author r.david.murray
Recipients kawai, loki_dePlume, r.david.murray
Date 2009-03-24.15:05:35
SpamBayes Score 3.1531394e-10
Marked as misclassified No
Message-id <1237907144.02.0.348892993604.issue2259@psf.upfronthosting.co.za>
In-reply-to
Content
The issue isn't whether the patch(es) are on one issue or not, if you
want to keep them here, that's fine.  This patch is so small that
breaking it up isn't strictly necessary, either, though I still think it
would be cleaner and more likely to get applied if you did so. (My
thought after reading the developer documentation is that each patch
file should consist of the minimum amount of independently testable
changes, regardless of whether or not they unltimately fix a single
issue.)  But I could be wrong, it's just my opinion :)

What we do for sure need in order to get this closer to having the devs
accept it is unit (or doctest) test cases that demonstrate the problem
and thereby demonstrate that the patch fixes the problem.

In case you didn't see it, it was also suggested, on the other ticket,
that the 'else: pass' could just be dropped.

(I'm one of the people doing ticket triage, by the way, in case you
wonder what my role is...my goal is to get tickets resolved, by getting
tickets up to a high enough quality that the devs can easily accept or
reject them.)
History
Date User Action Args
2009-03-24 15:05:44r.david.murraysetrecipients: + r.david.murray, loki_dePlume, kawai
2009-03-24 15:05:44r.david.murraysetmessageid: <1237907144.02.0.348892993604.issue2259@psf.upfronthosting.co.za>
2009-03-24 15:05:37r.david.murraylinkissue2259 messages
2009-03-24 15:05:35r.david.murraycreate