Message 81648 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	ajaksu2
Recipients	ajaksu2, amaury.forgeotdarc, georg.brandl, mark.dickinson, pitrou
Date	2009-02-11.15:04:19
SpamBayes Score	4.306891e-07
Marked as misclassified	No
Message-id	<1234364662.25.0.186809476472.issue3694@psf.upfronthosting.co.za>
In-reply-to

Content
Looks like both Undetected errors were corrected by Victor's patches, which Benjamin committed around rev66693, so trunk only needs a test. Here are the patches. I think IndexError fits better (and matches trunk), as the issue is that None is passed as "offset", which should be an Integral. If you disagree, I'll modify the patch. Is PyErr_Format'ing the exception desired? BTW, there's a warning in _struct.c:180 -> warning: ‘get_ulong’ defined but not used, should I open a new issue?

Looks like both Undetected errors were corrected by Victor's patches,
which Benjamin committed around rev66693, so trunk only needs a test.
Here are the patches.

I think IndexError fits better (and matches trunk), as the issue is that
None is passed as "offset", which should be an Integral. If you
disagree, I'll modify the patch. Is PyErr_Format'ing the exception desired? 

BTW, there's a warning in _struct.c:180 -> warning: ‘get_ulong’ defined
but not used, should I open a new issue?

History
Date	User	Action	Args
2009-02-11 15:04:22	ajaksu2	set	recipients: + ajaksu2, georg.brandl, amaury.forgeotdarc, mark.dickinson, pitrou
2009-02-11 15:04:22	ajaksu2	set	messageid: <1234364662.25.0.186809476472.issue3694@psf.upfronthosting.co.za>
2009-02-11 15:04:20	ajaksu2	link	issue3694 messages
2009-02-11 15:04:20	ajaksu2	create