This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mhammond
Recipients loewis, mhammond
Date 2009-01-28.02:17:39
SpamBayes Score 7.412597e-10
Marked as misclassified No
Message-id <1233109069.05.0.874307272319.issue5075@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the merging advice!

The patch to the build system is indeed trivial - unfortunately it also
failed to work correctly due to install.c using freopen, a CRT function,
to redirect the output.  Interestingly, this probably means that if
someone attempted to use python 2.6 to create a pure-python .exe
installer, they would fail to see any output when installed to earlier
Python versions (and vice-versa...)

I've worked up a patch for install.c which uses the win32 API to achieve
the same result using SetStdHandle() etc.  This technique requires the
handles to be redirected before the Python DLL is loaded, so I took the
opportunity to refactor things a little - we now have 2 locations that
perform the redirection instead of 3 but I didn't see huge benefit in
trying to knock that down to 1.

The patch is against the trunk but should also be applied to 2.6 and the
3.x branches.  I've tested the new code-paths using a 32bit trunk build
only but it should work the same everywhere.
History
Date User Action Args
2009-01-28 02:17:51mhammondsetrecipients: + mhammond, loewis
2009-01-28 02:17:49mhammondsetmessageid: <1233109069.05.0.874307272319.issue5075@psf.upfronthosting.co.za>
2009-01-28 02:17:46mhammondlinkissue5075 messages
2009-01-28 02:17:44mhammondcreate