Message 80290 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	jyasskin
Recipients	ajaksu2, blaisorblade, collinwinter, jyasskin, loewis, pitrou
Date	2009-01-20.22:57:12
SpamBayes Score	5.0844537e-05
Marked as misclassified	No
Message-id	<1232492233.77.0.999981842539.issue4941@psf.upfronthosting.co.za>
In-reply-to

Content
Minor comments on likely_object.diff: * Py_LIKELY() and Py_UNLIKELY() would be better spellings than likely() and unlikely(). * The definitions should go in pyport.h instead of object.h * Usually don't put spaces after the "#". * Probably #if the definitions of Py_LIKELY and Py_UNLIKELY instead of __builtin_expect so new compilers can easily add their own definitions.

Minor comments on likely_object.diff:
* Py_LIKELY() and Py_UNLIKELY() would be better spellings than likely()
and unlikely().
* The definitions should go in pyport.h instead of object.h
* Usually don't put spaces after the "#".
* Probably #if the definitions of Py_LIKELY and Py_UNLIKELY instead of
__builtin_expect so new compilers can easily add their own definitions.

History
Date	User	Action	Args
2009-01-20 22:57:13	jyasskin	set	recipients: + jyasskin, loewis, collinwinter, pitrou, ajaksu2, blaisorblade
2009-01-20 22:57:13	jyasskin	set	messageid: <1232492233.77.0.999981842539.issue4941@psf.upfronthosting.co.za>
2009-01-20 22:57:12	jyasskin	link	issue4941 messages
2009-01-20 22:57:12	jyasskin	create