Message79217
I don't like the current behaviour of Python on closed socket:
>>> import socket
>>> s=socket.socket(socket.AF_INET, socket.SOCK_STREAM)
>>> s.close()
>>> s.fileno()
-1
>>> s.getsockname()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
socket.error: [Errno 9] Bad file descriptor
Some operations are still allowed whereas the other raise an ugly
error message. Most (or all) operation on a closed socket should be
blocked by a socket.error.
My patch raises a socket.error("I/O operation on closed socket") for
most operations except:
- close(): it call be called twice (or more) (keep current behaviour)
- gettimeout(): should we raise an error?
- setblocking(), settimeout(): should we raise an error? Maybe yes
for setter but no for getter which would be inconsistent with
getpeername()...
The io library already has this behaviour: read(), write(), flush(),
etc. are blocked by a ValueError("I/O operation on closed file") (see
IOBase._check_closed in the io library).
Issue #4791 changes the behaviour of closed SocketIO object: fileno()
method raise a socket.error if it's closed even if the socket is still
open. |
|
Date |
User |
Action |
Args |
2009-01-06 00:31:04 | vstinner | set | recipients:
+ vstinner |
2009-01-06 00:31:03 | vstinner | set | messageid: <1231201863.3.0.481342348653.issue4853@psf.upfronthosting.co.za> |
2009-01-06 00:31:02 | vstinner | link | issue4853 messages |
2009-01-06 00:31:02 | vstinner | create | |
|